[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

steveire abandoned this revision. steveire added a comment. In D96142#2564265 , @njames93 wrote: > In D96142#2547418 , @steveire wrote: > >> In D96142#2545078 , @njames93 wro

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

njames93 added a comment. In D96142#2547418 , @steveire wrote: > In D96142#2545078 , @njames93 wrote: > >> I'm not sure about this. The warning is good and addresses a real problem. > > Well, I've made the diagnosti

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

steveire added a comment. In D96142#2545078 , @njames93 wrote: > I'm not sure about this. The warning is good and addresses a real problem. Well, I've made the diagnostic better anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

steveire updated this revision to Diff 321997. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96142/new/ https://reviews.llvm.org/D96142 Files: clang-tools-extra/clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

njames93 added a comment. I'm not sure about this. The warning is good and addresses a real problem. I'm not sure what the infrastructure surrounding this is but in clang it would show a "stack trace" of instantiations that result in this warning. Maybe we should think of something similar in c

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Don't issue a warning from within a template decla