This revision was automatically updated to reflect the committed changes.
Closed by commit rG6852a29a3b5b: [clang-tidy] Simplify function complexity
check (authored by stephenkelly).
Changed prior to commit:
https://reviews.llvm.org/D96131?vs=325226&id=325241#toc
Repository:
rG LLVM Github M
steveire updated this revision to Diff 325226.
steveire added a comment.
Fix test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96131/new/
https://reviews.llvm.org/D96131
Files:
clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexit
steveire updated this revision to Diff 325216.
steveire added a comment.
Trigger rebuild
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96131/new/
https://reviews.llvm.org/D96131
Files:
clang-tools-extra/clang-tidy/readability/FunctionCognitiveCo
njames93 added a comment.
Can you have a look at the failed tests, they seem to be related.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96131/new/
https://reviews.llvm.org/D96131
___
cfe-commits mailin
steveire added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:505
+ functionDecl(isDefinition(), unless(isWeak())).bind("func"), this);
+ Finder->addMatcher(lambdaExpr().bind("lambda"), this);
}
njames93 added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:505
+ functionDecl(isDefinition(), unless(isWeak())).bind("func"), this);
+ Finder->addMatcher(lambdaExpr().bind("lambda"), this);
}
steveire created this revision.
steveire added reviewers: aaron.ballman, njames93.
Herald added subscribers: nullptr.cpp, lebedev.ri, xazax.hun.
Herald added a reviewer: lebedev.ri.
steveire requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
U
