[PATCH] D96102: [clangd] Fix missing __syncthreads.

2021-02-05 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D96102#2545644 , @oToToT wrote: > OK, I've found what's wrong with my fix here. I should check for the clangd > compile mechanism with more detail to fix this problem. > > Sorry for disturbance. No worries. I'm not sure how

[PATCH] D96102: [clangd] Fix missing __syncthreads.

2021-02-05 Thread Tommy Chiang via Phabricator via cfe-commits
oToToT abandoned this revision. oToToT added a comment. OK, I've found what's wrong with my fix here. I should check for the clangd compile mechanism with more detail to fix this problem. Sorry for disturbance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96102/new/ https://reviews.l

[PATCH] D96102: [clangd] Fix missing __syncthreads.

2021-02-04 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I doubt this compiles: https://godbolt.org/z/c51v5d even with adjusted type, this fails because `__syncthreads` is a builtin (right now): https://godbolt.org/z/jP7e6h (and `__nvvm_bar_sync` requires an argument). CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D96102: [clangd] Fix missing __syncthreads.

2021-02-04 Thread Tommy Chiang via Phabricator via cfe-commits
oToToT updated this revision to Diff 321652. oToToT added a comment. I guess __nvvm_bar_sync is the right instruction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96102/new/ https://reviews.llvm.org/D96102 Files: clang/lib/Headers/__clang_cuda_device_functions.h Index: clang/lib/

[PATCH] D96102: [clangd] Fix missing __syncthreads.

2021-02-04 Thread Tommy Chiang via Phabricator via cfe-commits
oToToT created this revision. oToToT added reviewers: tra, chandlerc, jdoerfert, gtbercea, emankov, JDevlieghere. Herald added subscribers: usaxena95, kadircet, arphaman. oToToT requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project