[PATCH] D96049: [Timer] On macOS count number of executed instructions

ahoppen added inline comments. Comment at: llvm/CMakeLists.txt:656 + list(APPEND CMAKE_REQUIRED_LIBRARIES proc) +endif() + thakis wrote: > also, any reason to not do this in `llvm/cmake/config-ix.cmake` where all the > other checks like this are? No, I just did

[PATCH] D96049: [Timer] On macOS count number of executed instructions

thakis added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:356 +#cmakedefine HAVE_PROC_PID_RUSAGE 1 + thakis wrote: > Any reason to use `#cmakedefine` instead of `cmakedefine01` here? This type > of check usually uses `#cmakedefine01` in

[PATCH] D96049: [Timer] On macOS count number of executed instructions

thakis added inline comments. Comment at: llvm/CMakeLists.txt:656 + list(APPEND CMAKE_REQUIRED_LIBRARIES proc) +endif() + also, any reason to not do this in `llvm/cmake/config-ix.cmake` where all the other checks like this are? Repository: rG LLVM Github Mo

[PATCH] D96049: [Timer] On macOS count number of executed instructions

thakis added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:356 +#cmakedefine HAVE_PROC_PID_RUSAGE 1 + Any reason to use `#cmakedefine` instead of `cmakedefine01` here? This type of check usually uses `#cmakedefine01` in this file. Repo

[PATCH] D96049: [Timer] On macOS count number of executed instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e3b9aba609f: [Timer] On macOS count number of executed instructions (authored by ahoppen, committed by teemperor). Repository: rG LLVM Github Mon

[PATCH] D96049: [Timer] On macOS count number of executed instructions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Seems useful! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96049/new/ https://reviews.llvm.org/D96049 __

[PATCH] D96049: [Timer] On macOS count number of executed instructions

ahoppen updated this revision to Diff 321467. ahoppen added a comment. Fixed an issue caused by me using an old revions as the commit's base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96049/new/ https://reviews.llvm.org/D96049 Files: clang-

[PATCH] D96049: [Timer] On macOS count number of executed instructions

ahoppen created this revision. Herald added subscribers: dexonsmith, hiraditya, mgorny. ahoppen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In addition to wall time etc. this should allow us to get less noisy values fo