This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa2c1054c303f: [ASTReader] Always rebuild a cached module
that has errors (authored by bnbarham, committed by akyrtzi).
Repository:
rG LLVM Github
bnbarham updated this revision to Diff 321308.
bnbarham set the repository for this revision to rG LLVM Github Monorepo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95989/new/
https://reviews.llvm.org/D95989
Files:
clang/lib/Serialization/ASTRea
bnbarham updated this revision to Diff 321305.
bnbarham added a comment.
Added a couple semi-colons to the test file
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95989/new/
https://reviews.llvm.org/D95989
Files:
clang/lib/Serialization/ASTReader.cpp
clang/test/Modules/Inputs/error
bnbarham created this revision.
bnbarham added a reviewer: akyrtzi.
bnbarham requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
A module in the cache with an error should just be a cache miss. If
allowing errors (with -fallow-pcm-with-compiler