This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf74318491134: [clang][CodeComplete] Fix crash on
ParenListExprs (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
kadircet updated this revision to Diff 322077.
kadircet marked an inline comment as done.
kadircet added a comment.
- Update comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95935/new/
https://reviews.llvm.org/D95935
Files:
clang/lib/Sema/
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5173
+ if (auto *PLE = llvm::dyn_cast(Base))
+Base = PLE->getExpr(PLE->getNumExprs() - 1);
+ if (OtherOpBase) {
kadircet added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95935/new/
https://reviews.llvm.org/D95935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
kadircet updated this revision to Diff 321054.
kadircet added a comment.
- Also handle memberrefexpr case.
Fixes https://github.com/clangd/clangd/issues/676.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95935/new/
https://reviews.llvm.org/D95935
kadircet created this revision.
kadircet added a reviewer: hokein.
kadircet requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D95935
Files:
clang/lib/Sema/SemaCodeComplete.cpp
