This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG54afcade3bbc: [clangd] Report xref for base methods.
(authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: clang-tools-extra/clangd/XRefs.cpp:1294
+ OverriddenMethods.insert(ID);
+getOverriddenMethods(Base, OverriddenMethods);
+ }
The
usaxena95 updated this revision to Diff 321038.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95852/new/
https://reviews.llvm.org/D95852
Files:
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extra
usaxena95 added inline comments.
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1902
+void test(BaseBase* BB, Base* B, Derived* D) {
+ BB->func(); // refs to base's base method are not reported.
+ B->[[func]](); // References to the base
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1902
+void test(BaseBase* BB, Base* B, Derived* D) {
+ BB->func(); // refs to base's base method are not reported.
+ B->[[func]](); // References to the base me
usaxena95 created this revision.
Herald added subscribers: kadircet, arphaman.
usaxena95 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
See: https://github.com/clangd/clangd/issues/668
struct A { virtual void foo(
