[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

2021-02-08 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87dbdd2e3bb6: [FileCheck] Default --allow-unused-prefixes to false (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

2021-02-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added subscribers: pengfei, RKSimon. MaskRay added a comment. @nikic D95849 has already changed `llvm/test/` to default to `--allow-unused-prefixes`. I updated a few directories to be `--allow-unused-prefixes` clean (this uncovered improvement to many

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

2021-02-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 321524. MaskRay edited the summary of this revision. MaskRay added a comment. Rebase to re-cycle bots Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95849/new/ https://reviews.llvm.org/D95849 Files: clang/tes

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

2021-02-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D95849#2536559 , @nikic wrote: > Just to be clear here: Only the small handful where a spelling mistake was > fixed were actually bugs. All other unused check prefixes were there for > convenience, and are now casualties of th

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

2021-02-02 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. Just to be clear here: Only the small handful where a spelling mistake was fixed were actually bugs. All other unused check prefixes were there for convenience, and are now casualties of this unnecessary crusade. I regret not speaking out against this at the time. Repos

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

2021-02-02 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin added a comment. In D95849#2535939 , @jhenderson wrote: > I assume this now runs cleanly. If so, LGTM. Probably worth mentioning on the > mailing list thread too, so wrap up that conversation. By the way, did we > ever figure out how many of the

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

2021-02-02 Thread James Henderson via Phabricator via cfe-commits
jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. I assume this now runs cleanly. If so, LGTM. Probably worth mentioning on the mailing list thread too, so wrap up that conversation. By the way, did we ever figure out how many of the

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

2021-02-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: jdoerfert, jhenderson, mtrofin. Herald added subscribers: okura, kuter, thopre. MaskRay requested review of this revision. Herald added a reviewer: sstefan1. Herald added a reviewer: baziotis. Herald added subscribers: llvm-commits, cfe-commit