[PATCH] D95840: [CUDA][HIP] Fix checking dependent initalizer

2021-02-04 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rGe355110040d1: [CUDA][HIP] Fix checking dependent initalizer (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.or

[PATCH] D95840: [CUDA][HIP] Fix checking dependent initalizer

2021-02-03 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:538 AllowedInit = - ((VD->getType()->isDependentType() || Init->isValueDependent()) && - VD->isConstexpr()) || + (VD->getType()->isDep

[PATCH] D95840: [CUDA][HIP] Fix checking dependent initalizer

2021-02-02 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaCUDA.cpp:538 AllowedInit = - ((VD->getType()->isDependentType() || Init->isValueDependent()) && - VD->isConstexpr()) ||

[PATCH] D95840: [CUDA][HIP] Fix checking dependent initalizer

2021-02-01 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Defer constant checking of dependent initializer to template instantiation since it cannot be done for dependent values. This is separated from https://reviews.llvm.org/D95560 https://reviews.l