This revision was automatically updated to reflect the committed changes.
yaxunl marked 2 inline comments as done.
Closed by commit rGe355110040d1: [CUDA][HIP] Fix checking dependent initalizer
(authored by yaxunl).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.or
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Sema/SemaCUDA.cpp:538
AllowedInit =
- ((VD->getType()->isDependentType() || Init->isValueDependent()) &&
- VD->isConstexpr()) ||
+ (VD->getType()->isDep
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Sema/SemaCUDA.cpp:538
AllowedInit =
- ((VD->getType()->isDependentType() || Init->isValueDependent()) &&
- VD->isConstexpr()) ||
yaxunl created this revision.
yaxunl added a reviewer: tra.
yaxunl requested review of this revision.
Defer constant checking of dependent initializer to template instantiation
since it cannot be done for dependent values.
This is separated from https://reviews.llvm.org/D95560
https://reviews.l