[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbeff2ec2bc6: [clangd] Report only decl of overridding method in xref. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320737. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tool

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks great. Comment at: clang-tools-extra/clangd/XRefs.cpp:1387 +if (auto LSPLoc = +toLSPLocation(Object.CanonicalDeclaration, *MainFile

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320685. usaxena95 added a comment. Remove unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clangd/XRefs.cpp clang-tool

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320683. usaxena95 added a comment. Print value of new OverriddenBy flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 added a comment. In D95812#2535077 , @sammccall wrote: > This looks about right to me... > Unfortunately I landed ff4832dbff0ccf1fd29f726efe72fd1220cd645a > and > 1eb7fd089e2

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320673. usaxena95 added a comment. Rebase + Add OverriddenBy flag for such references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clan

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

sammccall added a comment. This looks about right to me... Unfortunately I landed ff4832dbff0ccf1fd29f726efe72fd1220cd645a and 1eb7fd089e2fcf3fe211f865b28e2fed12128c3f

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320563. usaxena95 added a comment. Move Index query to more logical place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. See: https://github.com/clangd/clangd/issues/668 struct A { virtual void foo(