[PATCH] D95782: [Syntax] Support condition for IfStmt.

2021-02-04 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c1a23303de9: [Syntax] Support condition for IfStmt. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D95782: [Syntax] Support condition for IfStmt.

2021-02-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:803 + bool TraverseIfStmt(IfStmt *S) { +bool Result = [&, this]() { sammccall wrote: > is it clear to you what all this code is doing? > It does seem to fit the pattern used e

[PATCH] D95782: [Syntax] Support condition for IfStmt.

2021-02-01 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:803 + bool TraverseIfStmt(IfStmt *S) { +bool Result = [&, this]() { is it clear to you wh

[PATCH] D95782: [Syntax] Support condition for IfStmt.

2021-02-01 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95782 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/Syntax/BuildT