[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd88c55ab95c9: [OpenCL] Add macro definitions of OpenCL C 3.0 features (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 __

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 321425. azabaznov added a comment. Adjusted test one more time: moved header functionality into separate test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files:

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/features.cl:1 +// RUN: %clang_cc1 -triple spir-unknown-unknown -finclude-default-header %s -E -dM -o - -x cl -cl-std=CL2.0 -cl-ext=-all \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=FEATURES -

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/features.cl:1 +// RUN: %clang_cc1 -triple spir-unknown-unknown -finclude-default-header %s -E -dM -o - -x cl -cl-std=CL2.0 -cl-ext=-all \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=FEATURES -

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/features.cl:1 +// RUN: %clang_cc1 -triple spir-unknown-unknown -finclude-default-header %s -E -dM -o - -x cl -cl-std=CL2.0 -cl-ext=-all \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=FEATURES -

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 321385. azabaznov added a comment. Features remain defined in header for OpenCL C 2.0; adjusted the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files: clan

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets.cpp:743 + // Assume compiling for FULL profile + Builder.defineMacro("__opencl_c_int64"); } azabaznov wrote: > Anastasia wrote: > > Btw we could add the other feature macros for earlier versi

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov added inline comments. Comment at: clang/lib/Basic/Targets.cpp:743 + // Assume compiling for FULL profile + Builder.defineMacro("__opencl_c_int64"); } Anastasia wrote: > Btw we could add the other feature macros for earlier versions too but I > gues

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

svenvh added inline comments. Comment at: clang/lib/Headers/opencl-c.h:17161 +#if (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ == 200) +#undef __opencl_c_pipes +#undef __opencl_c_generic_address_space Anastasia wrote: > Looping in @svenvh - I don't m

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia added a subscriber: svenvh. Anastasia added inline comments. Comment at: clang/lib/Basic/Targets.cpp:743 + // Assume compiling for FULL profile + Builder.defineMacro("__opencl_c_int64"); } Btw we could add the other feature macros for earlier version

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 320710. azabaznov added a comment. Rebased one more time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files: clang/include/clang/Basic/OpenCLExtensions.def cla

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 320708. azabaznov added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Basic/T

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov added a comment. I suggest that renaming 'extension' to 'option' (extensions + features) concept to be done in separate commit. There are a lot of places to change all over the place in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov created this revision. azabaznov added reviewers: Anastasia, mantognini. Herald added subscribers: jfb, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds possibility to define OpenCL C 3.0 feature m