[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad9e98b8efa0: [OpenMP] Do not propagate match extensions to nested contexts (authored by jdoerfert). Herald added subscribers: llvm-commits, hiradity

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. That sounds reasonable. We can probably expect features to be renamed and semantically adjusted on their way to standardisation anyway. Repository: rG LLVM Github Monorepo

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

jdoerfert added a comment. In D95764#2532927 , @JonChesterfield wrote: > I would have expected a nested match statement to hit on a subset of those > that matched in the parent. > > If (match x64) > If (match Intel) > > - expect x64 and intel to be true

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

JonChesterfield added a comment. I would have expected a nested match statement to hit on a subset of those that matched in the parent. If (match x64) If (match Intel) - expect x64 and intel to be true here I think that's how the normal openmp variant match works. Why do we want to diverge fr

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

jdoerfert added a comment. In D95764#2532908 , @tianshilei1992 wrote: > In D95764#2532877 , @jdoerfert wrote: > >> In D95764#2532875 , @tianshilei1992 >> wrote: >> >>> So I

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

jdoerfert updated this revision to Diff 320371. jdoerfert added a comment. Herald added a reviewer: aaron.ballman. Update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95764/new/ https://reviews.llvm.org/D95764 Files: clang/include/clang/Ba

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

tianshilei1992 added a comment. In D95764#2532877 , @jdoerfert wrote: > In D95764#2532875 , @tianshilei1992 > wrote: > >> So I suppose D95765 can replace this >> patch, right? > >

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

jdoerfert added a comment. In D95764#2532875 , @tianshilei1992 wrote: > So I suppose D95765 can replace this patch, > right? I think we want both. Propagating match clauses doesn't make sense to me so we should never d

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

tianshilei1992 added a comment. So I suppose D95765 can replace this patch, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95764/new/ https://reviews.llvm.org/D95764

[PATCH] D95764: [OpenMP] Do not propagate match extensions to nested contexts

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, tianshilei1992. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. If w