[PATCH] D95753: Store compilation dir separately in coverage mapping

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1131 NegFlag, BothFlags<[CoreOption]>>; +def fcoverage_compilation_dir : Separate<["-"], "fcoverage-compilation-dir">, +Group, Flags<[CC1Option, CC1AsOption, CoreOption]>, Us

[PATCH] D95753: Store compilation dir separately in coverage mapping

MaskRay added a comment. (I haven't read through the discussion.) -fprofile-prefix-map has been added. Does this option has overlap with that option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 __

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk added inline comments. Comment at: llvm/docs/CoverageMappingFormat.rst:277 +There is one difference between versions 6 and 5: + +There is one difference between versions 5 and 4: I think the above bullet point could go in this section? Repository: rG LLVM

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. The pre-merge checks appear to have flagged some issues, but I don't anticipate any major revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 323231. phosek added a comment. Documentation updated and test included. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOption

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk added a comment. Two minor missing items: - Please include a binary test that verifies llvm-cov can prepare a report for a binary containing a Version6 coverage blob (for compatibility testing). - Please also include a short blurb in docs/CoverageMappingFormat.rst explaining the format chan

[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 323106. phosek marked 2 inline comments as done. phosek added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. I have addressed all the comments and fixed all tests. I'm happy to slice this into multiple patches if you pref

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk added a comment. This looks great, that turned out to be a lot cleaner than I expected. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1717 + FilenameStrs[0] = getCurrentDirname(); + FilenameRefs[0] = FilenameStrs[0]; for (const auto &Entry : FileEntries) { -

[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek added a comment. In D95753#2534895 , @vsk wrote: > Thanks for pointing DW_AT_comp_dir out. For coverage, gating the use of > relative paths on a flag sounds reasonable to me. It should also be possible > to extend the .covmapping format to include

[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 322609. phosek retitled this revision from "[CoverageMapping] Don't absolutize source paths" to "Store compilation dir separately in coverage mapping". phosek edited the summary of this revision. Herald added subscribers: llvm-commits, dexonsmith, dang, sstefan