[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

thakis added a comment. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95739/new/ https://reviews.llvm.org/D95739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

steveire added a comment. In D95739#2536515 , @thakis wrote: > Looks like this doesn't link on windows: > http://45.33.8.238/win/32481/step_4.txt Thanks, should be fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

thakis added a comment. Looks like this doesn't link on windows: http://45.33.8.238/win/32481/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95739/new/ https://reviews.llvm.org/D95739 ___ cfe-c

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG467a04560143: [ASTMatchers] Add matchers for decomposition decls (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95739/new/ https://reviews.llvm.org/D95739 __

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

steveire updated this revision to Diff 320578. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95739/new/ https://reviews.llvm.org/D95739 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

aaron.ballman added a comment. Thanks for this! It generally looks good, aside from some minor nits. Btw, it looks like the HTML documentation wasn't regenerated for the patch. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7392 +/// Matches the DecompositionDecl

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

steveire created this revision. steveire added reviewers: aaron.ballman, alexfh. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95739 Files: clang/include/clang/A