This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rG59c1139d3ee1: [clangd] Expose more dependent-name detail via
semanticTokens (authored by sammccall).
Cha
nridge added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:78
Abstract,
+ DependentName,
sammccall wrote:
> nridge wrote:
> > Just `Dependent` might be enough
> AFAICS the current implementation is closer to "dependent name" t
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:239
+ auto Result = Priority1 > Priority2 ? Tokens[0] : Tokens[1];
+ Result.Modifiers = Tokens[0].Modifiers | Tokens[1].Modifiers;
+ retur
nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Looks great, thanks again for doing this!
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:239
+ auto Result = Priority1 > Priority2 ? Tokens[0] : Tokens[1];
+
sammccall created this revision.
sammccall added a reviewer: nridge.
Herald added subscribers: usaxena95, kadircet, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
This change makes dependentName a
