This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
hokein marked 3 inline comments as done.
Closed by commit rG78c22fbce991: [clangd] Don't rely on builtin headers
for document-link.test. (authored by hokein).
Reposito
hokein updated this revision to Diff 320454.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95670/new/
https://reviews.llvm.org/D95670
Files:
clang-tools-extra/clangd/test/document-link.test
Index: clan
sammccall accepted this revision.
sammccall added a comment.
Thanks for fixing this, we don't want to depend on clang and I didn't realize
we still did!
Comment at: clang-tools-extra/clangd/test/document-link.test:3
+# create a fake resource_dir so that the test can find the h
kadircet accepted this revision.
kadircet added a subscriber: sammccall.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm! but I would wait for a while to see if someone(that remembers why
this test was specifically asserting for built-in headers) will objec
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang.
This test seems to be failing at HEAD.
Repository:
rG LLVM
