[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

2021-01-29 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG632545e8ce84: [clang-tidy] Fix linking tests to LLVMTestingSupport (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

2021-01-29 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D95653#2530163 , @mgorny wrote: > In D95653#2529776 , @njames93 wrote: > >> I think I introduced this failure due to my abysmal In D95653#2530163

[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

2021-01-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95653/new/ https://reviews.llvm.org/D95653 ___ cfe-commits mailing list c

[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

2021-01-29 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. In D95653#2529776 , @njames93 wrote: > I think I introduced this failure due to my abysmal knowledge of CMake and > LLVM's library structure, So I'm definitely not qualified to say if this is a > good fix, but seeing as it fixes t