[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

gargaroff added a comment. This still breaks for us. The `find_package(Python3 ...)` from `Tooling/CMakeLists.txt` does not look for the minimum version and overrides the version that was already found through `llvm/CMakeLists.txt`. I opened D99715 to fix this

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39970764af39: [CMake] Require python 3.6 if enabling LLVM test targets (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

ctetreau added a comment. In D95635#2619804 , @serge-sans-paille wrote: > would it make sense to syndicate the minimal version in a single variable, > say `LLVM_MINIMAL_PYTHON_VERSION`, and use it in several place instead of > hard-coding the value acro

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

ctetreau updated this revision to Diff 330078. ctetreau added a comment. set a var for the minimum bound Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 Files: clang/CMakeLists.txt lld/CMakeLists.txt

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

serge-sans-paille added a comment. would it make sense to syndicate the minimal version in a single variable, say `LLVM_MINIMAL_PYTHON_VERSION`, and use it in several place instead of hard-coding the value across multiple files? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

ctetreau requested review of this revision. ctetreau added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___ cfe-commits mailing list cfe-commit