[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau updated this revision to Diff 329965. ctetreau added a comment. This revision is now accepted and ready to land. Only require if adding test suite targets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D9

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau planned changes to this revision. ctetreau added a comment. Herald added subscribers: dcaballe, cota. I plan to revive this patch. I will try to rig it to only require 3.6 or above is testing is enabled using LLVM_INCLUDE_TESTS. Hopefully if any build bots haven't been fixed by now, the

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

yln added a comment. My apologies for misrepresenting the meaning of the docs and stirring up this confusion. I did not read the docs carefully enough. Replying on the mailing list ... Comment at: clang/CMakeLists.txt:1 cmake_minimum_required(VERSION 3.13.4) -

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

JDevlieghere added a comment. Thanks for brining this up on the mailing list, I think that's a good place to discuss! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

MaskRay added a comment. https://lists.llvm.org/pipermail/llvm-dev/2021-January/148229.html "Python version requirement" for the version discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau added a comment. @JDevlieghere I personally have no skin in this game. This is actually quite an obnoxious development for me since my linux machine is stuck on an old version and Python 3.5 is the newest version in the repos. I sent a message to llvm-dev so hopefully this will get has

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

JDevlieghere reopened this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D95635#2529027 , @ctetreau wrote: > In D95635#2528851 , @JDevlieghere > wrote: > >>> However, t

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0703b0753c40: [CMake] Actually require python 3.6 or greater (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau added a comment. In D95635#2528851 , @JDevlieghere wrote: >> However, the project claims to require 3.6 or greater, and 3.6 features are >> being used. > > Can you link to where it says that? I'm not opposed to making 3.6 the > minimally requir

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

yln added a comment. In D95635#2528851 , @JDevlieghere wrote: >> However, the project claims to require 3.6 or greater, and 3.6 features are >> being used. > > Can you link to where it says that? I'm not opposed to making 3.6 the > minimally required ve

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

JDevlieghere added a comment. > However, the project claims to require 3.6 or greater, and 3.6 features are > being used. Can you link to where it says that? I'm not opposed to making 3.6 minimally required version, but at least for LLDB we don't have that requirement and we have documentation

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

yln added a comment. LGTM, thanks! (I got bitten by this.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau created this revision. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, mgorny. ctetreau requested review of this revision. Herald a