This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.
Closed by commit rGff4832dbff0c: [clangd] Respect
ReferencesParams.context.includeDeclarations (authored by sammccall).
Cha
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.h:86
+ enum ReferenceAttributes : unsigned {
+Plain = 0,
+Declaration = 1 << 0,
kbobyrev wrote:
> nit: `Plain` means neither `Declaration` nor `Definition`, right? Maybe
> `None
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM with a couple of nits.
Comment at: clang-tools-extra/clangd/XRefs.h:23
#include "clang/AST/Type.h"
+#include "clang/Basic/BitmaskEnum.h"
#include "clang/Fo
sammccall created this revision.
sammccall added a reviewer: kbobyrev.
Herald added subscribers: usaxena95, kadircet, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Unfortunately this treats overr
