[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman closed this revision. aaron.ballman added a comment. In D95396#2598932 , @rsmith wrote: > Looks like `test/FixIt/fixit-static-assert.cpp` is failing in Phabricator's > pre-merge checks: B91556 . Please take a

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rsmith added a comment. Looks like `test/FixIt/fixit-static-assert.cpp` is failing in Phabricator's pre-merge checks: B91556 . Please take a look at that before landing this; I think there's a decent chance that it's indicative of a real problem. CHANGES SINCE

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, but please make sure that Richard is happy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 ___ cf

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 327426. aaron.ballman added a comment. Address review comments from @rnk Only define the `static_assert` macro if one is not already defined and test the expected behavior. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://rev

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rnk added a comment. I guess my only concern is, what happens if MSVC fixes assert.h? Do we need to make the implicit `#define static_assert _Static_assert` conditional on the absence of any `static_assert` definition? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://r

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 325487. aaron.ballman added a comment. Rebasing on ToT. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticPars

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2884 +Tok.setKind(tok::kw__Static_assert); +Tok.setIdentifierInfo(getIdentifierInfo("_Static_assert")); +MI->AddTokenToBody(Tok); rsmith wrote: > Do we need to give the ex

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 325029. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 Files: clang/include/clang/Ba

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rsmith added a comment. @rnk / @thakis Can you take a look at this and see if you're happy with this "defining `assert` implicitly defines `static_assert`" approach? Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:427-429 +def warn_cxx_static_assert_in_c : Warnin

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 324707. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Bas

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getLocation(), "_Static_assert"); aaron.ballma

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getLocation(), "_Static_assert"); rsmit

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rsmith added a comment. FYI, https://reviews.llvm.org/D17444 captures some of the history here. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman marked 2 inline comments as not done. aaron.ballman added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman marked an inline comment as not done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getL

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getLocation(), "_Static_assert"); rsmit

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getLocation(), "_Static_assert"); I don't thin

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 319862. aaron.ballman added a comment. Rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, jyknight. aaron.ballman requested review of this revision. I noticed that our diagnostics relating to static assertions are a bit confused. For instance, when in MS compatibility mode in C (where we accept `static_assert