[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

2021-02-08 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c42d87ea8e0: [clang][cli] Generate and round-trip preprocessor options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

2021-01-31 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 320344. jansvoboda11 added a comment. Rebase, rename parse function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95366/new/ https://reviews.llvm.org/D95366 Files: clang/include/clang/Driver/Options.td

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

2021-01-29 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 320119. jansvoboda11 edited the summary of this revision. jansvoboda11 added a comment. Rename variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95366/new/ https://reviews.llvm.org/D95366 Files: cl

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

2021-01-29 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3093 + +static bool ParsePreprocessorArgs(PreprocessorOptions &Opts, ArgList &Args, DiagnosticsEngine &Diags, dexonsmith wrote: > Can we n

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

2021-01-28 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3093 + +static bool ParsePreprocessorArgs(PreprocessorOptions &Opts, ArgList &Args,