[PATCH] D95313: [WIP] Move part of nvptx devicertl under clang

2021-01-26 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield abandoned this revision. JonChesterfield added a comment. Abandoned in favour of multiple instantiations of the devicertl, which works across all languages and doesn't require hacks to clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D95313: [WIP] Move part of nvptx devicertl under clang

2021-01-24 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added a comment. In general we're moving to the direction that target specific implementation will be compiled along with user code, which is fantastic. In this way, we only need to provide one bitcode library for one target. The change in FE lacks of some efficiency. If user cod

[PATCH] D95313: [WIP] Move part of nvptx devicertl under clang

2021-01-24 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1204 +{ + auto *CTC = static_cast( + C.getSingleOffloadToolChain()); Logic very like this could pick out a second, small devicertl bitcode library ===

[PATCH] D95313: [WIP] Move part of nvptx devicertl under clang

2021-01-24 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: mgorny, jvesely. JonChesterfield requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP. [W