[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

This revision was automatically updated to reflect the committed changes. Closed by commit rGf05b492aae4d: [clangd][NFC] Simplify handing on methods with no params (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95270/new/ http

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:262 + template + void bind(const char *Method, +void (ClangdLSPServer::*Handler)(const NoParams &, kadircet wrote: > why do we need this one ? Good point, this

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

njames93 updated this revision to Diff 318942. njames93 marked an inline comment as done. njames93 added a comment. Remove unnecessary specialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95270/new/ https://reviews.llvm.org/D95270 Files:

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

sammccall added a comment. In D95270#2519052 , @sammccall wrote: > I'm not convinced this is clearer - these methods do in fact return `null`. > And it adds more duplicative code. Is it necessary? Doh, of course I misread - inputs rather than outputs. Yes

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

sammccall added a comment. I'm not convinced this is clearer - these methods do in fact return `null`. And it adds more duplicative code. Is it necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95270/new/ https://reviews.llvm.org/D95270 ___

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

kadircet added a comment. thanks this LG, but I suppose we can do some more trimming. after the trimming we are introducing a single partial specialization which is luckily more specialized than existing notification-binding specialization, so all should be fine. Comment at:

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Add bind methods handling the case