[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

This revision was automatically updated to reflect the committed changes. Closed by commit rGd92413a45e20: [clangd] Selection handles CXXBaseSpecifier (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95231/new/ https://reviews.l

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 updated this revision to Diff 318933. njames93 marked an inline comment as done. njames93 added a comment. Remove FindTarget to instead add in a follow up patch. Side note, Think I'll wait til after tomorrow to land this, unsure if the changes will break anything elsewhere. Repository:

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:272-283 + R"cpp( +struct Foo {}; +struct Bar : [[private Fo^o]] {}; + )cpp", + "CXXBaseS

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (I don't see a new snapshot but LG with the traverseNode change) Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:272-283 + R"cpp( +

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 updated this revision to Diff 318930. njames93 marked 2 inline comments as done. njames93 added a comment. Update behaviour to keep RecordTypeLoc seletion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95231/new/ https://reviews.llvm.org/D

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:496 } + bool TraverseCXXBaseSpecifier(const CXXBaseSpecifier &X) { +auto N = DynTypedNode::create(X); sammccall wrote: > can we n

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:496 } + bool TraverseCXXBaseSpecifier(const CXXBaseSpecifier &X) { +auto N = DynTypedNode::create(X); can we not use traverseNode here, rather than repeating? ==

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 added inline comments. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:272-283 + R"cpp( +struct Foo {}; +struct Bar : [[private Fo^o]] {}; + )cpp", + "CXXBaseSpecifier", + }, + { -

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 updated this revision to Diff 318523. njames93 added a comment. Update FindTargets to fix symbol renaming on a CXXBaseSpecifier. Add test to ensure rename wont trigger on a CXXBaseSpecifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D952

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 created this revision. njames93 added reviewers: kadircet, hokein, sammccall. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Selection now includes the