This revision was automatically updated to reflect the committed changes.
Closed by commit rG7044f1d875e3: [clangd] Use Dirty Filesystem for cross file
rename. (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95043/new/
https://
njames93 updated this revision to Diff 329354.
njames93 added a comment.
Update to assert that either Index and FS are both set, or neither set.
Document this behaviour.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95043/new/
https://reviews.llvm.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:408
+clangd::rename({Pos, NewName.getValueOr("__clangd_rename_dummy"),
+InpAST->AST, File, TFS.view(llvm::None),
+/*Index=*/nullptr, Renam
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.h:40
+ // The filesystem to query when performing cross file renames.
+ llvm::IntrusiveRefCntPtr FS;
sammccall wrote:
> Index + FS are both only used for cross-file renames a
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This looks pretty good, great cleanup!
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:408
+clangd::rename({Pos, NewName.getValueOr("__clangd_rename_dummy
njames93 updated this revision to Diff 329126.
njames93 added a comment.
Rebase and remove an addressed FIXME.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95043/new/
https://reviews.llvm.org/D95043
Files:
clang-tools-extra/clangd/ClangdServer.
njames93 updated this revision to Diff 323379.
njames93 added a comment.
Rebase and fix up tests after changes to rename.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95043/new/
https://reviews.llvm.org/D95043
Files:
clang-tools-extra/clangd/Cl
njames93 created this revision.
njames93 added reviewers: sammccall, kadircet.
Herald added subscribers: usaxena95, arphaman, javed.absar.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Refactor cross file r
