This revision was automatically updated to reflect the committed changes.
Closed by commit rG8fdd5784f0d3: [OpenCL][Docs] Describe tablegen BIFs
declarations. (authored by Anastasia).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D95038?vs=318208&id=318938#toc
svenvh accepted this revision.
svenvh added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95038/new/
https://reviews.llvm.org/D95038
___
cfe-commits mailing list
cfe-co
Anastasia added inline comments.
Comment at: clang/docs/OpenCLSupport.rst:132
+Note that this is a frontend-only flag and therefore it requires the use of
+flags that forward options to the frontend, e.g. ``-cc1`` or ``-Xclang``.
+
svenvh wrote:
> We should also
Anastasia updated this revision to Diff 318208.
Anastasia added a comment.
Added suggestions from Sven.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95038/new/
https://reviews.llvm.org/D95038
Files:
clang/docs/OpenCLSupport.rst
clang/docs/UsersManual.rst
Index: clang/docs/UsersM
svenvh added a comment.
Thanks for working on this!
Comment at: clang/docs/OpenCLSupport.rst:118
+
+In addition to regular header includes with builtin types/functions using
+``-finclude-default-header`` explained in :doc:`UsersManual` clang
Anastasia created this revision.
Anastasia added a reviewer: svenvh.
Herald added subscribers: ebevhan, yaxunl.
Anastasia requested review of this revision.
Added documentation for the fast builtin function declaration with
`-fdeclare-opencl-builtins`.
https://reviews.llvm.org/D95038
Files: