[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

yaxunl added a comment. In D95007#2638955 , @MaskRay wrote: > Should `-cuid=` be `--cuid=`? For the existing clang options, there seem to be no rule or convention whether to use - or --. For example, -rtlib= Compiler runtime library to use

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

MaskRay added a comment. Should `-cuid=` be `--cuid=`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95007/new/ https://reviews.llvm.org/D95007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rG98c21289f1d2: [CUDA][HIP] Add -fuse-cuid (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D95007?vs=322020&

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-cuid.hip:98 + +// RUN: rm -rf %t.out + tra wrote: > Is it necessary? The next 'RUN' command would overwrite the temp file anyways. > Also, you don't have to c

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Few test nits. LGTM in principle. Comment at: clang/test/Driver/hip-cuid.hip:98 + +// RUN: rm -rf %t.out + Is it necessary? The next 'RUN' command would overwrite

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

yaxunl updated this revision to Diff 322020. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Jon and Artem's comments. Removed check of CUID value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95007/new/ https://reviews.llvm.org/D95007 Files: clang/includ

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2307 + // Only alphanumeric and underscore is allowed in -cuid option. + if (auto *A = Args.getLastArg(OPT_cuid_EQ)) { +const char *V = A->getValue()

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

tra added inline comments. Herald added a reviewer: jansvoboda11. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2307 + // Only alphanumeric and underscore is allowed in -cuid option. + if (auto *A = Args.getLastArg(OPT_cuid_EQ)) { +const char *V = A->getValue(); ---

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

JonChesterfield added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2307 + // Only alphanumeric and underscore is allowed in -cuid option. + if (auto *A = Args.getLastArg(OPT_cuid_EQ)) { +const char *V = A->getValue(); Why this limi

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

JonChesterfield added subscribers: jdoerfert, JonChesterfield. JonChesterfield added a reviewer: jdoerfert. JonChesterfield added a comment. @jdoerfert this may be a candidate for deriving names of extracted target regions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95007/new/ https:

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added subscribers: dexonsmith, dang. yaxunl requested review of this revision. This patch added a distinct CUID for each input file, which is represented by InputAction. clang initially creates an InputAction for each inp