[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

2021-01-19 Thread Utkarsh Saxena via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17846ed5af4a: [clangd] Use ASTSignals in Heuristics CC Ranking. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

2021-01-19 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 317613. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added a comment about the calculation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94927/new/ https://reviews.llvm.org/D94927

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

2021-01-19 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Quality.cpp:477 + if (MainFileRefs >= 2) { +// E.g.: (2, 1.12), (9, 2.0), (48, 3.0). Can you add a comment ex

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

2021-01-18 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94927 Files: