[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG00054382b95a: [clangd] Fix a crash when indexing invalid ObjC method declaration (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94919/ne

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman accepted this revision. dgoldman added a comment. This revision is now accepted and ready to land. In D94919#2515987 , @adamcz wrote: > The crash happens while indexing the file, not during code completion. The > code completion tests generally s

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz added a comment. The crash happens while indexing the file, not during code completion. The code completion tests generally specify a cursor position, but in this case it is not relevant and could confuse the reader. This seemed like a logical place for indexing bug, in the spirit of usi

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman requested changes to this revision. dgoldman added a comment. This revision now requires changes to proceed. Looks good but I think for posterity we should add a similar test to clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp for the exact intended code complete behavior (or in

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1807-1811 +@interface Foo +- (void)fun:(bool)foo + bar:(bool)bar, + baz:(bool)baz; +@end dgoldman wrote: > It's hard to tell what Clang ma

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz updated this revision to Diff 318529. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94919/new/ https://reviews.llvm.org/D94919 Files: clang-tools-e

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1807-1811 +@interface Foo +- (void)fun:(bool)foo + bar:(bool)bar, + baz:(bool)baz; +@end It's hard to tell what Clang makes of this, I t

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This fix will make us not crash, but ideally we would handle this case bett