This revision was automatically updated to reflect the committed changes.
Closed by commit rGcbdde495ba28: [clang-format] Apply Allman style to lambdas
(authored by HazardyKnusperkeks).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94906/new/
https:
curdeius accepted this revision.
curdeius added a comment.
LGTM.
As a note, I agree with @MyDeveloperDay.
It's more user-friendly and IMO less surprising to set the base wrapping style
in `BreakBeforeBraces` and then customize it changing in `BraceWrapping`.
I'd argue that it won't be a breaking
HazardyKnusperkeks added a comment.
I think that would have helped me also. I think it's not that easy, but
honestly never checked.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94906/new/
https://reviews.llvm.org/D94906
_
MyDeveloperDay added a comment.
Similarly I see users having to define everything just to turn one thing off
{F15089845, size=full}
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94906/new/
https://reviews.llvm.org/D94906
___
MyDeveloperDay added a comment.
I think this is LGTM, however..
I've always felt that we shouldn't require `BreakBeforeBraces` to be `Custom`
in order to be able to use the BraceWrapping.
Users in my view should be able to say:
BreakBeforeBraces: Allman
BraceWrapping:
BeforeLambda
HazardyKnusperkeks updated this revision to Diff 317358.
HazardyKnusperkeks added a comment.
Formatting corrected.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94906/new/
https://reviews.llvm.org/D94906
Files:
clang/lib/Format/Format.cpp
clan
HazardyKnusperkeks created this revision.
HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius.
HazardyKnusperkeks added a project: clang-format.
HazardyKnusperkeks requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
According to https:
