[PATCH] D94880: Add clang-query support for mapAnyOf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04b69d9a6013: Add clang-query support for mapAnyOf (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94880?vs=320774&

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. In D94880#2544895 , @aaron.ballman wrote: > In D94880#2544873 , @steveire wrote: > >> That page collapses the documentation for each matcher, as you know. >> >> You need to expand the docs

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman accepted this revision. aaron.ballman added a comment. In D94880#2544873 , @steveire wrote: > That page collapses the documentation for each matcher, as you know. > > You need to expand the docs for `mapAnyOf`, as you know. > > You seem to kn

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. That page collapses the documentation for each matcher, as you know. You need to expand the docs for `mapAnyOf`, as you know. You seem to know all this. What's the remaining issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman added a comment. In D94880#2544782 , @steveire wrote: > @aaron.ballman Any further comments? Thank you for pinging, this fell off my queue! The only further comments I have about about my confusion with `with`. In D94880#2536485

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. @aaron.ballman Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. In D94880#2536399 , @aaron.ballman wrote: > I think there should be some documentation change for the new `with` > functionality. It's already documented in https://clang.llvm.org/docs/LibASTMatchersReference.html , just like

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire updated this revision to Diff 320774. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 Files: clang/include/clang/ASTMatchers/Dynamic/Diagnostics.h clang/include

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman added a comment. I think there should be some documentation change for the new `with` functionality. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:398-407 + bool isBuilderMatcher() const override { return false; } + + std::unique_ptr + buildMatcherCt

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:697 - if (IsPolymorphic) { -OS << "Matcher " << Name << "(Matcher"; + std::string TypedText = std::string(Name); + aaron.ballman wrote: > Any reason this de

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire updated this revision to Diff 320593. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 Files: clang/include/clang/ASTMatchers/Dynamic/Diagnostics.h clang/include

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/Dynamic/Registry.h:36-37 +/// A smart (owning) pointer for MatcherDescriptor +/// We can't use unique_ptr because MatcherDescriptor is forward declared +class MatcherDescriptorPtr { ---

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. @aaron.ballman Please review this again as I've merged some more needed changes into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 __

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire updated this revision to Diff 319431. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 Files: clang/include/clang/ASTMatchers/Dynamic/Diagnostics.h clang/include

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:1081 +if (NodeKinds.empty()) { + // Set error + return {}

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94880 Files: clang/lib/ASTMatchers/Dynami