[PATCH] D94820: Support for instrumenting only selected files or functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9eb1982980: Support for instrumenting only selected files or functions (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D94820?vs=319359&id=319444#toc Repository: rG LLVM Git

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added inline comments. Comment at: clang/docs/UsersManual.rst:2271 +.. option:: -fprofile-list= + MaskRay wrote: > This can be added below `-fprofile-exclude-files=` I considered it but that's in the GCOV section and this flag only applies to the LLVM i

[PATCH] D94820: Support for instrumenting only selected files or functions

MaskRay added inline comments. Comment at: clang/docs/UsersManual.rst:2271 +.. option:: -fprofile-list= + This can be added below `-fprofile-exclude-files=` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added a comment. In D94820#2523461 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/32075/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks for the heads up, I suspect it m

[PATCH] D94820: Support for instrumenting only selected files or functions

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/32075/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.ll

[PATCH] D94820: Support for instrumenting only selected files or functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG4edf35f11a9e: Support for instrumenting only selected files or functions (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D94820?vs=318257&id=319359#toc Repository: rG LLVM Git

[PATCH] D94820: Support for instrumenting only selected files or functions

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. my bad -- I missed the test case. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 ___ cfe

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added inline comments. Comment at: clang/test/CodeGen/profile-filter.c:17 +// RUN: %clang_cc1 -fprofile-instrument=clang -fprofile-list=%t-exclude-only.list -emit-llvm %s -o - | FileCheck %s --check-prefix=EXCLUDE + +unsigned i; davidxl wrote: > phosek w

[PATCH] D94820: Support for instrumenting only selected files or functions

davidxl added inline comments. Comment at: clang/test/CodeGen/profile-filter.c:17 +// RUN: %clang_cc1 -fprofile-instrument=clang -fprofile-list=%t-exclude-only.list -emit-llvm %s -o - | FileCheck %s --check-prefix=EXCLUDE + +unsigned i; phosek wrote: > davidxl

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added inline comments. Comment at: clang/test/CodeGen/profile-filter.c:17 +// RUN: %clang_cc1 -fprofile-instrument=clang -fprofile-list=%t-exclude-only.list -emit-llvm %s -o - | FileCheck %s --check-prefix=EXCLUDE + +unsigned i; davidxl wrote: > Can you

[PATCH] D94820: Support for instrumenting only selected files or functions

davidxl added inline comments. Comment at: clang/test/CodeGen/profile-filter.c:17 +// RUN: %clang_cc1 -fprofile-instrument=clang -fprofile-list=%t-exclude-only.list -emit-llvm %s -o - | FileCheck %s --check-prefix=EXCLUDE + +unsigned i; Can you add a test case

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek marked an inline comment as done. phosek added a comment. @davidxl @vsk do you have any further comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 ___ cfe-commits mailing list cfe-commits

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:851 +return "csllvm"; + default: +llvm_unreachable("unknown instrumentation type"); vsk wrote: > If we add an instrumenta

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek updated this revision to Diff 318257. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 Files: clang/docs/SourceBasedCodeCoverage.rst clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/LangOptions.h clang/include/clang/Bas

[PATCH] D94820: Support for instrumenting only selected files or functions

vsk added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:851 +return "csllvm"; + default: +llvm_unreachable("unknown instrumentation type"); If we add an instrumentation kind, it may be more convenient to trigger a -Wcove

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek marked an inline comment as not done. phosek added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2591 + } + return false; +} davidxl wrote: > phosek wrote: > > davidxl wrote: > > > If the profile list contains only one line of exclude

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek updated this revision to Diff 318132. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 Files: clang/docs/SourceBasedCodeCoverage.rst clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/LangOptions.h clang/include/clang/Bas

[PATCH] D94820: Support for instrumenting only selected files or functions

davidxl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2591 + } + return false; +} phosek wrote: > davidxl wrote: > > If the profile list contains only one line of exclude list, it seems that > > all functions will be rejected as the fu

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added inline comments. Comment at: clang/docs/SourceBasedCodeCoverage.rst:86 +.. code-block:: none + + # all functions whose name starts with foo will be instrumented. davidxl wrote: > what is the default section name? It's `*` which always matches. ===

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek updated this revision to Diff 317796. phosek marked 3 inline comments as done. Herald added a reviewer: jansvoboda11. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 Files: clang/docs/SourceBasedCodeCoverage.rst clang/include/clang/AST/

[PATCH] D94820: Support for instrumenting only selected files or functions

davidxl added inline comments. Comment at: clang/docs/SourceBasedCodeCoverage.rst:77 +the files and functions specified in ``file.list`` will be instrumented. The +option can be specified multiple times to pass multiple files: + perhaps documenting how compiler

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek created this revision. phosek added reviewers: davidxl, vsk, gulfem. Herald added subscribers: dexonsmith, wenlei, dang, jdoerfert, steven_wu, hiraditya, mgorny. phosek requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits