[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG98a8344895a8: [clang][ASTImporter] Add support for importing CXXFoldExpr. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ h

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:642-649 +const internal::VariadicDynCastAllOfMatcher cxxFoldExpr; + +AST_MATCHER_P(CXXFoldExpr, hasOperator, BinaryOperatorKind, Op) { + return Node.getOperator() == Op; +} +AST_MATCHER(CXXFoldEx

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:642-649 +const internal::VariadicDynCastAllOfMatcher cxxFoldExpr; + +AST_MATCHER_P(CXXFoldExpr, hasOperator, BinaryOperatorKind, Op) { + return Node.getOperator() == Op; +} +AST_MATCHER(CXXFoldEx

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

shafik accepted this revision. shafik added a comment. LGTM, thank you for expanding the test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.llvm.org/D94786 ___ cfe-commits mai

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

martong accepted this revision. martong added a comment. Thanks for the update! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.llvm.org/D94786 ___ cfe-commits mailing list cfe-c

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske updated this revision to Diff 317894. balazske added a comment. Removed use of `auto`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.llvm.org/D94786 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/A

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks! Comment at: clang/lib/AST/ASTImporter.cpp:8019 + auto ToType = importChecked(Err, E->getType()); + auto ToCallee = importChecked(Err, E->getCall

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:655 + Lang_CXX17, "", Lang_CXX17, Verifier, + functionTemplateDecl(hasDescendant(cxxFoldExpr(; +} shafik wro

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske updated this revision to Diff 317278. balazske added a comment. Improved test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.llvm.org/D94786 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImport

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:655 + Lang_CXX17, "", Lang_CXX17, Verifier, + functionTemplateDecl(hasDescendant(cxxFoldExpr(; +} Is it possible to check that we imported four fold expr

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske added a reviewer: martong. balazske added a comment. Herald added a subscriber: rnkovacs. There is a related bug report: https://bugs.llvm.org/show_bug.cgi?id=48004 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.l

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske created this revision. Herald added subscribers: martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reposi