[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bf7116d50bf: [clangd] Index local classes, virtual and overriding methods. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 added a comment. In D94785#2506685 , @hokein wrote: > if you don't mind, could you rerun the benchmark (we have a behavior changes > from original version, I guess it won't not change significantly)? and update > the data in the description bef

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good! if you don't mind, could you rerun the benchmark (we have a behavior changes from original version, I guess it won't not change significantly)? and update the data in the

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317525. usaxena95 added a comment. Herald added a subscriber: wenlei. Updated index tests's input files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files: clan

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317522. usaxena95 added a comment. Index all member functions instead of only polymorphic functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files: clang-to

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 marked an inline comment as done. usaxena95 added a comment. In D94785#2506186 , @hokein wrote: > I think we'd better bump the index version, even though this is not a > breaking change, but we will collect more data. Not bumping the index versi

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

hokein added a comment. mostly good. I think we'd better bump the index version, even though this is not a breaking change, but we will collect more data. Not bumping the index version may lead to a half-completed state of the index (e.g. only newly-changed files will get completed index data

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317339. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Left a todo to fix the bug in RefContainers later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ h

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

hokein added a comment. In D94785#2503939 , @nridge wrote: > In D94785#2501806 , @usaxena95 wrote: > >> Although now that I enabled this in all SymbolCollectorTests, this causes a >> regression in RefContainers. >>

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

nridge added a comment. In D94785#2501806 , @usaxena95 wrote: > Although now that I enabled this in all SymbolCollectorTests, this causes a > regression in RefContainers. > > void f2() { > (void) $ref1a[[f1]](1); > auto fptr = &$ref1b[[f

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 added a comment. In D94785#2501312 , @njames93 wrote: > My only question is does this try and index lambdas, under the hood they are > declared as a CXXRecordDecl, defined in function scope? I would not expect that to happen as it is an anonymo

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317015. usaxena95 added a comment. Added tests for not indexing lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files: clang-tools-extra/clangd/index/FileI

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

njames93 added a comment. Thank you for taking the time to fix this and the performance measurements to boot. My only question is does this try and index lambdas, under the hood they are declared as a CXXRecordDecl, defined in function scope? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Previously we did not record local class declarations. Now with features like fi