[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

This revision was automatically updated to reflect the committed changes. Closed by commit rG38b185832e04: [analyzer][CTU] API for CTU macro expansions (authored by steakhal, committed by Balazs Benics ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:835 + CTU.getMacroExpansionContextForSourceLocation(MacroExpansionLoc)) { +return CTUMacroExpCtx->getExpandedText(MacroExpansionLoc); } balazske wrote:

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

balazske accepted this revision. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:835 + CTU.getMacroExpansionContextForSourceLocation(MacroExpansionLoc)) { +return CTUMacroExpCtx->getExpandedText(MacroExpansionLoc); }

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! You may wanna wait for someone more knowledgeable about CTU to give it another accept. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94673/new/ https://reviews.llvm.org/D

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

steakhal updated this revision to Diff 323025. steakhal added a comment. Actually, somehow I messed up something previously. Now, the diff contains the latest version. Sorry for the inconvenience! Rebased on top of 2407eb08a5748bc2613e95fa449fc1cae6f4ff8f

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

steakhal added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:191 + /// source-location, empty is returned. + /// \note Macro expansion tracking for imported TUs are not implemented yet. + /// It returns empty unconditionally. -

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

vsavchenko added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:186 - /// Determine the original source location in the original TU for an - /// imported source location. + /// Returns the MacroExpansionContext for the imported TU to which th

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

steakhal updated this revision to Diff 316861. steakhal edited the summary of this revision. steakhal set the repository for this revision to rG LLVM Github Monorepo. steakhal added a comment. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. U