[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks abandoned this revision. aeubanks added a comment. https://reviews.llvm.org/D94825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/ https://reviews.llvm.org/D94644 ___ cfe-commits mailin

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

mtrofin added a comment. In D94644#2498638 , @aeubanks wrote: > It's not an emergency. > The issue with InlineAdvisorAnalysis is that the ModuleInlineWrapperPass > presets the InliningAdvisorMode of the InlineAdvisorAnalysis. We could force > override it

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks added a comment. It's not an emergency. The issue with InlineAdvisorAnalysis is that the ModuleInlineWrapperPass presets the InliningAdvisorMode of the InlineAdvisorAnalysis. We could force override it, but then what's the point of InlineAdvisorAnalysis? Can't we just create an InlineA

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

mtrofin added a comment. In D94644#2497180 , @aeubanks wrote: > An alternative is to run the mandatory inliner in the same CGSCC pipeline as > everything else, but the way InlineAdvisorAnalysis is setup made it hard to > implement I don't remember there

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks added a comment. An alternative is to run the mandatory inliner in the same CGSCC pipeline as everything else, but the way InlineAdvisorAnalysis is setup made it hard to implement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks added a comment. In D94644#2497125 , @mtrofin wrote: > Would running the function simplification pipeline after the always inline > pass address the issue? Probably yes, but last time we measured the compile time implications of that, it was ve

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

mtrofin added a comment. Would running the function simplification pipeline after the always inline pass address the issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/ https://reviews.llvm.org/D94644 _

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks updated this revision to Diff 316550. aeubanks added a comment. test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/ https://reviews.llvm.org/D94644 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll clang/test/Fronte

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks created this revision. Herald added subscribers: wenlei, steven_wu, hiraditya, eraman. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. And revert much of D91567 . D91567 <