[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon abandoned this revision. segoon added a comment. see https://reviews.llvm.org/D94622#2617417 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

aaron.ballman added a comment. In D94621#2554228 , @segoon wrote: > alexfh, aaron.ballman, hi! Any comments on the patch? Have you run this check over large real-world code bases beyond Yandex.Taxi? I think this is likely to be a maintenance burden becau

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. alexfh, aaron.ballman, hi! Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon updated this revision to Diff 322695. segoon added a comment. Herald added a subscriber: nullptr.cpp. - explicitly state in docs that the check must be used only for async code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 Files: clan

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

Eugene.Zelenko added a comment. In D94621#2509324 , @segoon wrote: > Eugene.Zelenko, njames93, any comments on the patch? Sorry, you need to wait for approval from one of maintainers mentioned as reviewers. I check only documentation and for minor code i

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. Eugene.Zelenko, njames93, any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. Eugene.Zelenko, thanks for the review! fixed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon updated this revision to Diff 316667. segoon added a comment. - use back-ticks - fix the first document line - add default values CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 Files: clang-tools-extra/clang-tidy/concurrency/AsyncFsChe

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/concurrency-async-fs.rst:6 + +Search for filesystem accesses that might block current system thread. +Asynchronous code may deal with it in numerous ways, the most widespread --

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. njames93, the purpose is to flag it indeed. This approach was found valueable in Yandex.Taxi, as it is very easy to forget that you're in a coroutine and may not use blocking API. The bug does affect performance (e.g. all coroutine threads wait for fs), it cannot be foun

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

njames93 added a reviewer: aaron.ballman. njames93 added a comment. Is this just flagging all these functions, if so I don't think there's much value in here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 _

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon updated this revision to Diff 316460. segoon retitled this revision from "docs" to "[clang-tidy] add concurrency-async-fs". segoon edited the summary of this revision. segoon added a comment. Herald added subscribers: ormris, xazax.hun, mgorny. fix CHANGES SINCE LAST ACTION https://rev