This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGde4ba7073bd7: [clangd] Move DirBasedCDB broadcasting onto
its own thread. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.o
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:496
+ std::condition_variable CV;
+ std::atomic ShouldStop = {false}; // Must notify CV
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:496
+ std::condition_variable CV;
+ std::atomic ShouldStop = {false}; // Must notify CV after writing.
+ std::deque Queue;
kadircet wrote:
> nit: we already hol
sammccall updated this revision to Diff 317365.
sammccall marked an inline comment as done.
sammccall added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94606/new/
https://reviews.llvm.org/D94606
Files:
clang-tools-e
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:496
+ std::condition_variable CV;
+ std::atomic ShouldStop = {false}; // Must notify CV after writing.
+ std::deque Queue;
nit: we already hold the lock within t
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, jfb, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
This is on the critical path (it blo
