[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0250b053b5aa: [clangd] Add a Filesystem that overlays Dirty files. (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D94554?vs=329070&id=329319#toc Repository: rG LLVM Github

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

sammccall accepted this revision. sammccall added a comment. Still LG btw! Comment at: clang-tools-extra/clangd/ClangdServer.h:342 - llvm::Optional getDraft(PathRef File) const; + std::shared_ptr getDraft(PathRef File) const; Maybe add an explicit comment

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/DraftStore.cpp:287 +for (const auto &KV : DS.Drafts) { + // Query the base filesystem for file uniqueids. + auto BaseStatus = BaseView->status(KV.getKey()); njames93 wrote: > njam

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 329070. njames93 marked 2 inline comments as done. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 Files: clang-tools-ext

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 marked 11 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:389 + + class DirtyFS : public ThreadsafeFS { + public: sammccall wrote: > njames93 wrote: > > Probably needs moving to its own place

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, LG! Comment at: clang-tools-extra/clangd/ClangdServer.h:389 + + class DirtyFS : public ThreadsafeFS { + public: njames93 wrote: > Probably ne

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:389 + + class DirtyFS : public ThreadsafeFS { + public: Probably needs moving to its own place, but wasn't sure where best to put it. Comment at: clang-tools-

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/DraftStore.h:37 + DraftStore(const ThreadsafeFS &BaseFS); + sammccall wrote: > having DraftStore sit on top of TFS seems a bit inside-out, giving it bigger > scope than necessary. > > What

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 327646. njames93 added a comment. Getting there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-ex

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

sammccall added a comment. In D94554#2595625 , @njames93 wrote: > Address some comments, though I have a feeling @Sammccall, I may have to wait > until DraftStore has been refactored first before continuing on with this. D97738

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 327280. njames93 marked an inline comment as done. njames93 added a comment. Address some comments, though I have a feeling @Sammccall, I may have to wait until DraftStore has been refactored first before continuing on with this. Repository: rG LLVM Gith

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 marked 3 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:159 ClangdServer(const GlobalCompilationDatabase &CDB, const ThreadsafeFS &TFS, - const Options &Opts, Callbacks *Callbacks = nullptr);

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

sammccall added a comment. Sorry for the long delay here. I've gotten myself buried in too many different things. Overall the idea of exposing drafts as an overlay FS is definitely growing on me - it makes it easier and clearer to control which feature is seeing which version of the files. At

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 323378. njames93 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clan