This revision was automatically updated to reflect the committed changes.
Closed by commit rG2e25be0b6134: [clangd] Add main file macros into the
main-file index. (authored by ArcsinX).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94477/new/
https:
ArcsinX updated this revision to Diff 316331.
ArcsinX added a comment.
- std::pair => struct MacroOccurrence
- remove addressed fixme comment
- assert() => cantFail()
- use toSourceCode() to get the macro name
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llv
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Ah, this is a bit ugly... I'm not really happy with our representation of info
extracted from the preprocessor, but that's something to tackle another time.
Thanks for fixing this!
==
kadircet added a comment.
Ah this is really unfortunate :( In theory we already know which slabs belong
to main file while updating the index for the preamble, as we shard them per
file. But it is really inconvenient layering wise to transfer that slab from
`updatePreamble` to `updateMain` in p
ArcsinX added reviewers: sammccall, kadircet.
ArcsinX added a comment.
I am not happy with my solution, hope to hear an advice.
Initial discussion about this problem: https://reviews.llvm.org/D93683#2468842
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
ArcsinX created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
ArcsinX requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
This patch is a try to fix `WorkspaceSymbols.Macros` test after D93796
<
