This revision was automatically updated to reflect the committed changes.
Closed by commit rG275716d6db79: [clangd] Derive new signals in CC from
ASTSignals. (authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94473/new/
https://r
usaxena95 updated this revision to Diff 317307.
usaxena95 marked an inline comment as done.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94473/new/
https://reviews.llvm.org/D94473
Files:
clang-tool
adamcz added inline comments.
Comment at: clang-tools-extra/clangd/Quality.cpp:349
+ };
+ DeriveASTSignals();
// Declarations are scoped, others (like macros) are assumed global.
Maybe it's just me, but using a lambda like this seems quite confusing. I don't
usaxena95 updated this revision to Diff 316853.
usaxena95 added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94473/new/
https://reviews.llvm.org/D94473
Files:
clang-tools-extra/clangd/ClangdServer.cpp
clang-tools-extra/clan
usaxena95 updated this revision to Diff 316071.
usaxena95 added a comment.
Edge cases fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94473/new/
https://reviews.llvm.org/D94473
Files:
clang-tools-extra/clangd/ClangdServer.cpp
clang-tools-ex
usaxena95 created this revision.
Herald added subscribers: kadircet, arphaman.
usaxena95 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D94473
Files:
