This revision was automatically updated to reflect the committed changes.
Sunil_Srivastava marked an inline comment as done.
Closed by commit rGf706486eaf07: Fix for crash in __builtin_return_address in
template context. (authored by Sunil_Srivastava).
Changed prior to commit:
https://reviews.l
Sunil_Srivastava marked an inline comment as done.
Sunil_Srivastava added inline comments.
Comment at: clang/test/Sema/builtin-returnaddress.c:3
// RUN: %clang_cc1 -fsyntax-only -Wmost -verify %s
+// RUN: %clang_cc1 -x c++ -fsyntax-only -Wframe-address -verify %s
+// RUN: %clang
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Fix looks fine, I'm on the fence about how to handle the test, whether it is
valuable to convert it to a C++ test and omit the #ifdef/extra run line, or
leave it as it is (without the
Sunil_Srivastava created this revision.
Sunil_Srivastava added reviewers: jstenglein, erichkeane.
Sunil_Srivastava requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The check for the value passed to __buildtin_return_address needs to be guard
