This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f395b7092bd: [clangd] Make AST-based signals available to
runWithPreamble. (authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES
usaxena95 updated this revision to Diff 316683.
usaxena95 marked an inline comment as done.
usaxena95 added a comment.
Added newline at end of new file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94424/new/
https://reviews.llvm.org/D94424
Files
usaxena95 updated this revision to Diff 316681.
usaxena95 added a comment.
Addressed comments. Ready for landing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94424/new/
https://reviews.llvm.org/D94424
Files:
clang-tools-extra/clangd/ASTSignals
sammccall accepted this revision.
sammccall added a comment.
Thanks!
Comment at: clang-tools-extra/clangd/ASTSignals.cpp:9
+ ASTSignals Signals;
+ llvm::DenseMap> NSDToSymbols;
+ const SourceManager &SM = AST.getSourceManager();
this requires storing all the
usaxena95 updated this revision to Diff 316670.
usaxena95 added a comment.
Removed unused headers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94424/new/
https://reviews.llvm.org/D94424
Files:
clang-tools-extra/clangd/ASTSignals.cpp
clang-to
usaxena95 added inline comments.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:841
+void ASTWorker::updateASTSignals(ParsedAST &AST) {
+ ASTSignals Signals;
sammccall wrote:
> This implementation doesn't belong in TUScheduler, which is all about
> mana
usaxena95 updated this revision to Diff 316669.
usaxena95 marked 13 inline comments as done.
usaxena95 added a comment.
Herald added a subscriber: mgorny.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94424/new/
https://reviews.
sammccall added a comment.
Thanks, this looks pretty solid!
I want to be pretty careful about APIs/naming/code organization here (even
moreso than usual!) because TUScheduler is a big complex beast as it is, and
it's easy to get lost.
Comment at: clang-tools-extra/clangd/TUS
usaxena95 added inline comments.
Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:720
+ #include "foo.h"
+ namespace ns1 {
+ namespace ns2 {
adamcz wrote:
> Can you add anonymous namespaces as well?
Good point. Avoided capturing anonymous na
usaxena95 updated this revision to Diff 316379.
usaxena95 marked 4 inline comments as done.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94424/new/
https://reviews.llvm.org/D94424
Files:
clang-tool
adamcz added inline comments.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:858
+std::string RelatedNS = OS.str();
+if (!RelatedNS.empty()) {
+ Signals.RelatedNamespaces[RelatedNS + "::"] += 1;
nit: I think you can just
usaxena95 updated this revision to Diff 315839.
usaxena95 added a comment.
Documentation change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94424/new/
https://reviews.llvm.org/D94424
Files:
clang-tools-extra/clangd/TUScheduler.cpp
clang-too
usaxena95 created this revision.
Herald added subscribers: kadircet, arphaman, javed.absar.
usaxena95 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Many useful signals can be derived from a valid AST which is regula
13 matches
Mail list logo
