[PATCH] D94390: [clangd] Extend find-refs to include overrides.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42830f8bdc8f: [clangd] Extend find-refs to include overrides. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

hokein added a comment. In D94390#2491046 , @njames93 wrote: > Should we be providing virtual method overrides when finding references, > surely that's what query implementations is for? yeah, go-to-implementation is designed for this purpose. However, n

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

hokein updated this revision to Diff 317832. hokein marked an inline comment as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94390/new/ https://reviews.llvm.org/D94390 Files: clang-tools-ext

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

njames93 added a comment. Should we be providing virtual method overrides when querying definitions, surely that's what query implementations is for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94390/new/ https://reviews.llvm.org/D94390 ___

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LG. Thanks! Comment at: clang-tools-extra/clangd/XRefs.cpp:1324 + +llvm::DenseSet OverrideSymbols; +if (Index) { nit: s/OverrideSymbols/Overrid

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

hokein created this revision. hokein added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. find-references on `virtual void meth^od() = 0` will include ov