This revision was automatically updated to reflect the committed changes.
Closed by commit rG31732e6f52c8: [clangd] Remove ScratchFS from tests (authored
by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94359/new/
https://reviews.llvm.org
njames93 updated this revision to Diff 315735.
njames93 added a comment.
Remove extra semi-colon.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94359/new/
https://reviews.llvm.org/D94359
Files:
clang-tools-extra/clangd/unittests/GlobalCompilatio
kadircet added inline comments.
Comment at:
clang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp:277
+ llvm::formatv(CDB, llvm::sys::path::convert_to_slash(testRoot()));
+ ;
EXPECT_THAT(Command("x/foo.cc"), Contains("-DXYZZY"));
nit: ex
adamcz accepted this revision.
adamcz added a comment.
This revision is now accepted and ready to land.
Thanks, that's better than my hacky workaround!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94359/new/
https://reviews.llvm.org/D94359
__
njames93 updated this revision to Diff 315596.
njames93 added a comment.
Fix windows tests failing(hopefully).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94359/new/
https://reviews.llvm.org/D94359
Files:
clang-tools-extra/clangd/unittests/Glo
njames93 created this revision.
njames93 added reviewers: adamcz, hokein, sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
This can lead to i
