[PATCH] D94293: [clangd] automatically index STL

kuhnel abandoned this revision. kuhnel added a comment. thx for the review and feedback! I guess I'll re-design the feature and add a new indexing layer instead. However that might take a while, so I'll abandon this revision and start a new one later on. Repository: rG LLVM Github Monorepo

[PATCH] D94293: [clangd] automatically index STL

sammccall added a comment. In D94293#2486468 , @njames93 wrote: > How does this approach work with differing language standards. For example > with an old implementation designed for c++14, `string_view` header won't > exist. If the implementation is des

[PATCH] D94293: [clangd] automatically index STL

kadircet added a comment. In D94293#2486468 , @njames93 wrote: > How does this approach work with differing language standards. For example > with an old implementation designed for c++14, `string_view` header won't > exist. If the implementation is desi

[PATCH] D94293: [clangd] automatically index STL

njames93 added a comment. How does this approach work with differing language standards. For example with an old implementation designed for c++14, `string_view` header won't exist. If the implementation is designed to work with c++17, including that header in c++14 mode will probably be ifdef.

[PATCH] D94293: [clangd] automatically index STL

kuhnel added a comment. Yes, I was looking for feedback on this one as I wasn't happy with my design. Comment at: clang-tools-extra/clangd/index/Background.cpp:449 + // TODO(kuhnel): is the a better place to store this file? + // TODO(kuhnel): do we need a file at all, can we

[PATCH] D94293: [clangd] automatically index STL

kadircet added a comment. (not sure if you were looking for comments yet, but i was just passing by and it was a small-ish patch, so couldn't resist :D) Comment at: clang-tools-extra/clangd/index/Background.cpp:449 + // TODO(kuhnel): is the a better place to store this file?

[PATCH] D94293: [clangd] automatically index STL

kuhnel added a comment. @sammccall here the first implementation we talked about yesterday. This works well on my testing poject that has a compile_commands.json. It does not work without one. Also I'm not really happy with the design as I haven't really found a good place to store the generat

[PATCH] D94293: [clangd] automatically index STL

kuhnel created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. kuhnel requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94293 Fil