[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki added a comment. > This revision was landed with ongoing or failed builds. The only failures were clang-format warnings, they looked bogus to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17f8c458de63: [clang] Use SourceLocations in unions [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 __

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki updated this revision to Diff 316414. miyuki added a comment. Refactored `SLocEntry` in a similar way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 Files: clang/include/clang/AST/DependentDiagno

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki added a comment. In D94237#2493844 , @dblaikie wrote: > Do you need to run the destructor before placement new in these situations? No, because there is no active union member in any of those situations. And if even if there was an active member,

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

dblaikie added a comment. Do you need to run the destructor before placement new in these situations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 ___ cfe-comm

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki updated this revision to Diff 315759. miyuki added a comment. Fixed a typo in the word "implicit" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 Files: clang/include/clang/AST/DependentDiagnostic.

[PATCH] D94237: [clang] Use SourceLocations in unions

miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl, rsmith. Herald added a subscriber: jfb. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, there are many instances where `SourceLocation` objects are