This revision was automatically updated to reflect the committed changes.
Closed by commit rGc1e08f0073e3: [clang][AST] Get rid of an alignment hack in
DeclObjC.h [NFCI] (authored by miyuki).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94224/new/
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
That's even better!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94224/new/
https://reviews.llvm.org/D94224
miyuki added inline comments.
Comment at: clang/include/clang/AST/DeclObjC.h:660
+ /// Location of the left and right angle brackets.
+ alignas(ObjCTypeParamDecl *) SourceRange Brackets;
/// The number of parameters in the list, which are tail-allocated.
apr
miyuki updated this revision to Diff 315601.
miyuki edited the summary of this revision.
miyuki added a comment.
Removed alignas
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94224/new/
https://reviews.llvm.org/D94224
Files:
clang/include/clang/
aprantl added inline comments.
Comment at: clang/include/clang/AST/DeclObjC.h:660
+ /// Location of the left and right angle brackets.
+ alignas(ObjCTypeParamDecl *) SourceRange Brackets;
/// The number of parameters in the list, which are tail-allocated.
Ca
miyuki updated this revision to Diff 315113.
miyuki added a comment.
Fixed formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94224/new/
https://reviews.llvm.org/D94224
Files:
clang/include/clang/AST/DeclObjC.h
clang/lib/AST/DeclObjC.cp
miyuki created this revision.
miyuki added reviewers: dexonsmith, aprantl.
miyuki requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch utilizes the `alignas` specifier and removes the workaround
which used a union object for the same
